Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 通过将日志上传改为异步改善竞争问题 #1063

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

PaienNate
Copy link
Contributor

#1034 ,按comment方式提交一个PR。

@PaienNate PaienNate requested a review from a team October 14, 2024 11:21
@PaienNate PaienNate changed the title fix:试图通过新开线程的方式,缓解#1034的问题。 fix:试图缓解#1034的问题 Oct 14, 2024
@fy0
Copy link
Member

fy0 commented Oct 14, 2024

代码倒是很简单,虽然不是根本解决,但如果自测中确实证明缓解了那就合并。
建议在上传函数中加句注释,并指向相关issue,以免未来对为什么要开协程迷惑

dice/ext_log.go Outdated Show resolved Hide resolved
@Xiangze-Li Xiangze-Li changed the title fix:试图缓解#1034的问题 fix: 通过将日志上传改为异步改善竞争问题 Oct 15, 2024
@Xiangze-Li Xiangze-Li merged commit b7feaa5 into sealdice:master Oct 15, 2024
1 of 2 checks passed
@PaienNate PaienNate deleted the fix_log_export branch October 20, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants